[PATCH] D45641: Rename sys::Process::GetArgumentVector -> sys::windows::GetCommandLineArguments

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

Android doesn't currently need this, but I can see this being needed on other platforms in the future and I think there is value in having a single point where you can guarantee to get normalized command line arguments on any platform (by exposing something like GetArgumentVector).

That said, since it is only used in InitLLVM right now and InitLLVM should be included in any application, I am convinced InitLLVM can replace that single point for getting normalized command line arguments. Do please rename SaveString, but other than that, it looks good.


https://reviews.llvm.org/D45641