[PATCH] D41949: [RISCV] implement li pseudo instruction

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

Thanks again Mario. I've reviewed the new RISCVISelDAGToDAG changes and just have a minor comment. This is also looking good when testing with the torture suite. I'll commit this as soon as you can confirm my minor query.

I'll think more about compression handling. If you already have something that works, it might be worth just posting that so we have something concrete to discuss.



================
Comment at: lib/Target/RISCV/RISCVISelDAGToDAG.cpp:196
+
+      int64_t Hi42 = (Const->getSExtValue() + 0x800) & ~0xFFF;
+      SDValue HiVal = CurDAG->getTargetConstant(Hi42, SDLoc(ImmOperand),
----------------
Perhaps I'm missing something obvious, but shouldn't this be 'Hi52'?


https://reviews.llvm.org/D41949