[PATCH] D44887: [RISCV] Add shouldForceRelocationWithApplyFixup MC AsmBackend Target Hook

[Shiva Chen via Phabricator via llvm-commits]

shiva0217 added a comment.

In https://reviews.llvm.org/D44887#1069641, @asb wrote:

> In https://reviews.llvm.org/D44887#1069639, @shiva0217 wrote:
>
> > In https://reviews.llvm.org/D44887#1069614, @asb wrote:
> >
> > > In https://reviews.llvm.org/D44887#1069573, @shiva0217 wrote:
> > >
> > > > I think it should be `if (!Resolved && WasForced) return fixupNeedsRelaxation(Fixup, Value, DF, Layout);`
> > >
> > >
> > > I don't think we want a call from fixupNeedsRelaxationAdvanced -> fixupNeedsRelaxation.
> >
> >
> > I thought we will need call fixupNeedsRelaxation, because WasForced is true means the symbol could be resovled, but the offset could fit in or not would need fixupNeedsRelaxation to identify.
> >  Is that reasonable?
>
>
> Hexagon at least just has fixupNeedsRelaxation assert, as all logic is in one place in fixupNeedsRelaxationAdvanced. That seems a sensible way of doing things.


OK, that makes sense.


Repository:
  rL LLVM

https://reviews.llvm.org/D44887