[PATCH] D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree

[Hideki Saito via Phabricator via llvm-commits]

hsaito added a comment.

Thanks, Renato for the feedback.

In https://reviews.llvm.org/D45420#1068297, @rengolin wrote:

> So, I never liked `LoopUtils` and I agree a lot of it should go to `Analysis` but having two copies of `LoopUtils` is bound to confuse people when including the headers.


I fully agree with you, and I actually expected someone to bring it up. On the other hand, my main motivation was to bring those two classes to Analysis and much less on how I name files, I decided to wait for someone else to speak up for the file naming issues.

> Induction and reduction analysis is very core to the vectoriser, that's why it's always been there. I'd prefer a more specific approach like naming it `InductionAnalysis` or `RecurrenceAnalysis` and only moving those parts out to `Analysis`.

I can further split this into InductionAnalysis.h/.cpp and RecurrenceAnalysis.h/.cpp, instead of LoopUtils.h/.cpp ----- if they are the names we'd like to settle. I believe I moved only the class member functions and the static file scope functions called from the member functions. If you think those static file scope functions should be moved into private static functions of the class, I can do that as a separate patch. I'd rather keep this patch as a plain "move".


Repository:
  rL LLVM

https://reviews.llvm.org/D45420