[PATCH] D45536: Do not keep shared symbols to garbage-collected eliminated DSOs.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 16 16:45:58 PDT 2018


espindola added a comment.

In https://reviews.llvm.org/D45536#1069314, @rnk wrote:

> This is causing LLD to drop __cxa_finalize from the symbol tables of some Chromium binaries, and that causes them to crash on shutdown. See the test failures here:
>  https://ci.chromium.org/buildbot/chromium.clang/ToTLinux/2152
>
> I'm going to revert this for now. I found that re-linking just libipc_mojom_shared.so and libmojo_mojom_bindings_shared.so with LLD after this change causes ipc_tests to crash reliably on shutdown.


Could you please put a --reproduce package of those libraries in a bug report? Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D45536





More information about the llvm-commits mailing list