[PATCH] D45709: LoadStoreVectorizer crashes due to unsized type

[Charu Chandrasekaran via Phabricator via llvm-commits]

charukcs created this revision.
charukcs added reviewers: marcello.maggioni, bogner, rampitec.
Herald added subscribers: llvm-commits, rengolin.

When we skip bitcasts while looking for GEP in LoadSoreVectorizer we should also verify that the type is sized otherwise we assert


Repository:
  rL LLVM

https://reviews.llvm.org/D45709

Files:
  lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
  test/CodeGen/X86/loadStore_vectorizer.ll


Index: test/CodeGen/X86/loadStore_vectorizer.ll
===================================================================
--- test/CodeGen/X86/loadStore_vectorizer.ll
+++ test/CodeGen/X86/loadStore_vectorizer.ll
@@ -0,0 +1,17 @@
+; RUN: opt -load-store-vectorizer < %s -S | FileCheck %s 
+
+%struct_render_pipeline_state = type opaque
+
+define fastcc void @main(%struct_render_pipeline_state addrspace(1)* %pso) unnamed_addr {
+; CHECK: load i16
+; CHECK: load i16
+entry:
+  %0 = bitcast %struct_render_pipeline_state addrspace(1)* %pso to i16 addrspace(1)*
+  %1 = load i16, i16 addrspace(1)* %0, align 2
+  %2 = bitcast %struct_render_pipeline_state addrspace(1)* %pso to i8 addrspace(1)*
+  %sunkaddr51 = getelementptr i8, i8 addrspace(1)* %2, i64 6
+  %3 = bitcast i8 addrspace(1)* %sunkaddr51 to i16 addrspace(1)*
+  %4 = load i16, i16 addrspace(1)* %3, align 2
+  ret void
+}
+
Index: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
===================================================================
--- lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
+++ lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
@@ -284,8 +284,10 @@
   // in pointee type size here. Currently it will not be vectorized.
   Value *SrcPtr = getLoadStorePointerOperand(Src);
   Value *SrcBase = SrcPtr->stripPointerCasts();
-  if (DL.getTypeStoreSize(SrcPtr->getType()->getPointerElementType()) ==
-      DL.getTypeStoreSize(SrcBase->getType()->getPointerElementType()))
+  Type *SrcPtrType = SrcPtr->getType()->getPointerElementType();
+  Type *SrcBaseType = SrcBase->getType()->getPointerElementType();
+  if (SrcPtrType->isSized() && SrcBaseType->isSized() &&
+      DL.getTypeStoreSize(SrcPtrType) == DL.getTypeStoreSize(SrcBaseType))
     SrcPtr = SrcBase;
   return dyn_cast<GetElementPtrInst>(SrcPtr);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45709.142712.patch
Type: text/x-patch
Size: 1790 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180416/d59c16a1/attachment.bin>