[PATCH] D45703: Use a utility function to speed up "process load image" for POSIX Platforms

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

First round of comments. Thanks for this!



================
Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:1075-1078
+  lldb::addr_t return_addr = process->CallocateMemory(2*addr_size,
+                                                      permissions,
+                                                      utility_error);
+  if (utility_error.Fail()) {
----------------
Where the `2*addr_size` is coming from? Probably we should add a comment.


================
Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:1117
+  options.SetLanguage(eLanguageTypeC_plus_plus);
+  options.SetIgnoreBreakpoints(true);
+  options.SetUnwindOnError(true);
----------------
why are we ignoring breakpoints?


================
Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:1121
+                                    // don't do the work to trap them.
+  options.SetTimeout(std::chrono::seconds(2));
+  
----------------
Shouldd we try setting up a slightly more generous timeout?


Repository:
  rL LLVM

https://reviews.llvm.org/D45703