[PATCH] D45645: Remove faulty assertion in llvm-pdbutil

[Adrian McCarthy via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330135: Remove faulty assertion in llvm-pdbutil (authored by amccarth, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D45645?vs=142489&id=142658#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D45645

Files:
  llvm/trunk/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp


Index: llvm/trunk/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
===================================================================
--- llvm/trunk/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
+++ llvm/trunk/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
@@ -50,12 +50,9 @@
     uint32_t RelativeOffset = Item->getOffsetInParent();
     CurrentAbsoluteOffset = ClassOffsetZero + RelativeOffset;
 
-    // Since there is storage there, it should be set!  However, this might
-    // be an empty base, in which case it could extend outside the bounds of
-    // the parent class.
+    // This might be an empty base, in which case it could extend outside the
+    // bounds of the parent class.
     if (RelativeOffset < UseMap.size() && (Item->getSize() > 0)) {
-      assert(UseMap.test(RelativeOffset));
-
       // If there is any remaining padding in this class, and the offset of the
       // new item is after the padding, then we must have just jumped over some
       // padding.  Print a padding row and then look for where the next block


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45645.142658.patch
Type: text/x-patch
Size: 1077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180416/276e485a/attachment.bin>