[llvm] r330133 - Revert "Fix some incorrect fields in our generated PDBs."

[Zachary Turner via llvm-commits]

Author: zturner
Date: Mon Apr 16 09:55:41 2018
New Revision: 330133

URL: http://llvm.org/viewvc/llvm-project?rev=330133&view=rev
Log:
Revert "Fix some incorrect fields in our generated PDBs."

There are a couple of failing tests which slipped under my radar
so I'm reverting this while I attempt to fix.

Modified:
    llvm/trunk/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
    llvm/trunk/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp

Modified: llvm/trunk/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h?rev=330133&r1=330132&r2=330133&view=diff
==============================================================================
--- llvm/trunk/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h (original)
+++ llvm/trunk/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h Mon Apr 16 09:55:41 2018
@@ -46,7 +46,6 @@ public:
   void setVersionHeader(PdbRaw_DbiVer V);
   void setAge(uint32_t A);
   void setBuildNumber(uint16_t B);
-  void setBuildNumber(uint8_t Major, uint8_t Minor);
   void setPdbDllVersion(uint16_t V);
   void setPdbDllRbld(uint16_t R);
   void setFlags(uint16_t F);

Modified: llvm/trunk/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp?rev=330133&r1=330132&r2=330133&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp Mon Apr 16 09:55:41 2018
@@ -37,14 +37,6 @@ void DbiStreamBuilder::setAge(uint32_t A
 
 void DbiStreamBuilder::setBuildNumber(uint16_t B) { BuildNumber = B; }
 
-void DbiStreamBuilder::setBuildNumber(uint8_t Major, uint8_t Minor) {
-  BuildNumber = (uint16_t(Major) << DbiBuildNo::BuildMajorShift) &
-                DbiBuildNo::BuildMajorMask;
-  BuildNumber |= (uint16_t(Minor) << DbiBuildNo::BuildMinorShift) &
-                 DbiBuildNo::BuildMinorMask;
-  BuildNumber |= DbiBuildNo::NewVersionFormatMask;
-}
-
 void DbiStreamBuilder::setPdbDllVersion(uint16_t V) { PdbDllVersion = V; }
 
 void DbiStreamBuilder::setPdbDllRbld(uint16_t R) { PdbDllRbld = R; }
@@ -259,7 +251,7 @@ Error DbiStreamBuilder::finalize() {
   H->TypeServerSize = 0;
   H->SymRecordStreamIndex = SymRecordStreamIndex;
   H->PublicSymbolStreamIndex = PublicsStreamIndex;
-  H->MFCTypeServerIndex = 0; // Not sure what this is, but link.exe writes 0.
+  H->MFCTypeServerIndex = kInvalidStreamIndex;
   H->GlobalSymbolStreamIndex = GlobalsStreamIndex;
 
   Header = H;