[PATCH] D45372: [AMDGPU] Fix issues for backend divergence tracking
David Stuttard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 16 08:23:15 PDT 2018
dstuttard added a comment.
In https://reviews.llvm.org/D45372#1068792, @alex-t wrote:
> In https://reviews.llvm.org/D45372#1068728, @dstuttard wrote:
>
> >
>
>
>
>
> > 2. Remove the test altogether since the VirtReg2Value.clear() is definitely required and was originally missed as an oversight - and the test might be overkill.
>
> Sounds reasonable. It really was an oversight :) It's funny that the change was reviewed by lots of people for 2 months but nobody noticed not clearing state.
Ok - I agree. I'll remove that test and submit the change. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D45372
More information about the llvm-commits
mailing list