[PATCH] D45181: [RISCV] Add diff relocation support for RISC-V

Simon Cook via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 16 03:29:18 PDT 2018


simoncook updated this revision to Diff 142607.
simoncook added a comment.

I've rebased the change on top of https://reviews.llvm.org/D44886 to indicate what is conditional based on linker relaxation.

I haven't made `hilo-constaddr-invalid.s` rejected unconditionally. I took a look at how to do this, and it seems it's more difficult to do that (considering fixup types on parent expressions when evaluating subexpressions) than it may be worth it, than to have this accepted based on the linker flag. If the latter is the behavior we want in the end, we already have that and I propose leaving it this way around.


Repository:
  rL LLVM

https://reviews.llvm.org/D45181

Files:
  include/llvm/MC/MCAsmBackend.h
  include/llvm/MC/MCFixup.h
  lib/MC/MCAsmBackend.cpp
  lib/MC/MCAssembler.cpp
  lib/MC/MCExpr.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVELFObjectWriter.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.cpp
  test/MC/RISCV/fixups-expr.s
  test/MC/RISCV/hilo-constaddr-invalid.s
  test/MC/RISCV/hilo-constaddr.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45181.142607.patch
Type: text/x-patch
Size: 12568 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180416/bcaf7287/attachment.bin>


More information about the llvm-commits mailing list