[PATCH] D45617: [IRCE] Only check for NSW on equality predicates

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

For me it looks fine, but please let me run some tests with this patch. I don't see obvious problem, and if they aren't revealed by this testing, I'll give my approval. It will take few hours.



================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:933
 
+  ConstantInt *StepCI = cast<SCEVConstant>(StepRec)->getValue();
+  assert(!StepCI->isZero() && "Zero step?");
----------------
mkazantsev wrote:
> How about non-constant steps?
Never mind, it's checked above. Could have been a dyn_cast on line 923.


https://reviews.llvm.org/D45617