[PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)
Brooks Moses via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 16 01:16:50 PDT 2018
brooksmoses added a comment.
Some further statistics, now that I've done a full cleanup on our code:
8 actual bugs newly found by -Wself-assign-field. (Thank you!)
2 actual bugs newly found by -Wself-assign
6 instances of redundant code newly found by -Wself-assign
90 (approximately) instances of intentional self assignments in tests that now need "*&" annotations.
That seems like an awfully large amount of noise for the -Wself-assign part of this, and I continue feeling rather dubious about whether it should be part of -Wall. By contrast, the -Wself-assign-field part has been entirely true positives.
Repository:
rC Clang
https://reviews.llvm.org/D44883
More information about the llvm-commits
mailing list