[PATCH] D45647: Limit the MaxSteps used in hasPredessorHelper

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added a comment.

Hi Tom,

please can you attach a patch with more context? See http://www.llvm.org/docs/Phabricator.html#phabricator-request-review-web

Also the function `hasPredecessorHelperMaxSteps` does not seem to follow the coding style in the variable names, see http://www.llvm.org/docs/CodingStandards.html#introduction

Kind regards,



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13264
     if (SDNode::hasPredecessorHelper(StoreNodes[i].MemNode, Visited, Worklist,
-                                     Max))
+                                     SDNode::hasPredecessorHelperMaxSteps()))
       return false;
----------------
I'm not sure to understand the whole change: doesn't this call return always compute 32*4 - 4?

If so, why using a function in the first place instead of adjusting `Max` above?


Repository:
  rL LLVM

https://reviews.llvm.org/D45647