[llvm] r330102 - [SelectionDAG][NFC] haveNoCommonBitsSet(): add FIXME notes

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 15 11:59:38 PDT 2018


Author: lebedevri
Date: Sun Apr 15 11:59:38 2018
New Revision: 330102

URL: http://llvm.org/viewvc/llvm-project?rev=330102&view=rev
Log:
[SelectionDAG][NFC] haveNoCommonBitsSet(): add FIXME notes

As suggested in https://reviews.llvm.org/D45631#1068338

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=330102&r1=330101&r2=330102&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Sun Apr 15 11:59:38 2018
@@ -3636,6 +3636,8 @@ bool SelectionDAG::isEqualTo(SDValue A,
   return false;
 }
 
+// FIXME: unify with llvm::haveNoCommonBitsSet.
+// FIXME: could also handle masked merge pattern (X & ~M) op (Y & M)
 bool SelectionDAG::haveNoCommonBitsSet(SDValue A, SDValue B) const {
   assert(A.getValueType() == B.getValueType() &&
          "Values must have the same type");




More information about the llvm-commits mailing list