[PATCH] D45244: Add missing vtable anchors

[Weiming Zhao via Phabricator via llvm-commits]

weimingz added a comment.

In https://reviews.llvm.org/D45244#1064905, @dblaikie wrote:

> Great - thanks for sticking with it, sorry for my dodgy explanations!
>
> If you're adding in anchors, are you using -Wweak-vtables to find them? If you're pushing through to make LLVM (& hopefully Clang/other LLVM subprojects) -Wweak-vtables clean, perhaps you can turn on the warning in the CMake config once it's clean so we don't regress this again? (it'd also be interesting to do some kind of analysis to see whether avoiding weak vtables is /actually/ worthwhile - like maybe making a temporary/local/non-committed change to change all the explicit anchors into inline functions (unanchoring them) & see if builds are much larger or longer, etc)


I got linker error when my code tries to statically link against some LLVM libs (like libLLVMOrc). It's a good idea to turn on -Wweak-vtables to check if we miss other cases. I will try it. Thanks


Repository:
  rL LLVM

https://reviews.llvm.org/D45244