[PATCH] D45549: [DWARF v5] improved support for .debug_rnglists/consumer

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:255
+    if (Error Err = Rnglists.extract(rnglistData, &Offset)) {
+      errs() << "error: " + toString(std::move(Err)) << '\n';
+      uint64_t Length = Rnglists.length();
----------------
wolfgangp wrote:
> aprantl wrote:
> > Not your code, but since you touched it: IIRC there's supposed to be a helper function that prints "error:" in color somewhere in libDebugInfo.
> Found it. So far it seems to be only used by the verifier.
I've added convenience methods in WithColor (rL330091) and I've updated the other uses in libDebugInfo (rL330092).


https://reviews.llvm.org/D45549