[PATCH] D45572: [X86] Replace action Promote with Custom for operation ISD::SINT_TO_FP

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added reviewers: spatel, efriedma.
RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/sitofp.ll:3
+
+target triple = "i386-unknown-linux-gnu"
+
----------------
This test needs improving - you need to add proper FileCheck testing, preferably use the update_llc_test_checks script to check all codegen and cleanup the actual test - I'm not convinced you need all this code to demonstrate the sitofp?


Repository:
  rL LLVM

https://reviews.llvm.org/D45572