[PATCH] D45457: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_report.cc:20
+#include "sanitizer_report_decorator.h"
+#include "sanitizer_stacktrace.h"
+#include "sanitizer_stacktrace_printer.h"
----------------
vitalybuka wrote:
> most of this code was in _libcdep.cc
> now its in the file without prefix, so in common file
> could this be a problem?
As far as I can tell, this didn't matter anywhere.
I think the _libcdep suffixes could go away for RTSanitizerCommonCoverage & RTSanitizerCommonSymbolizer files if the contract is that they are libc-dependent by nature. The only nolibc consummer that I can see is SafeStack, which depends on neither, so the distinction between libc & nolibc could be reduced to only the core RTSanitizerCommon files.

Once this lands, I can see some added value to consolidating headers & removing dead code as well to see if the distinction can be further reduced.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D45457