[PATCH] D45637: [DebugInfo] Ignore DBG_VALUE instructions in PostRA Machine Sink

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 13 14:29:27 PDT 2018


mattd created this revision.
mattd added reviewers: junbuml, johannes.
mattd added a project: debug-info.
Herald added subscribers: JDevlieghere, kristof.beyls.

The logic for handling sinking of COPY instructions was returning
prematurely due to the placement of DBG_VALUE call instructions.

The original logic intentionally ignores all call instructions. Since debug intrinsics
are represented as calls, the pass was skipping that block and not
performing the sink. This resulted in different code being generated for
optimized-with-debug-info  and optimized-without-debug-info.

I didn't want to create a new test for this; however, I wasn't able to cleanly insert the test into test/CodeGen/AArch64/post-ra-machine-sink.mir, since I would need to
stub out, in llvm-ir, the other functions in that test.


https://reviews.llvm.org/D45637

Files:
  lib/CodeGen/MachineSink.cpp
  test/CodeGen/X86/postra-ignore-dbg-intrinsics.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45637.142466.patch
Type: text/x-patch
Size: 4144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180413/3a7ef25a/attachment.bin>


More information about the llvm-commits mailing list