[PATCH] D44184: Write DWARF data into WASM object file

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 13 09:31:58 PDT 2018


sbc100 added inline comments.


================
Comment at: include/llvm/Object/RelocVisitor.h:323
+
+  uint64_t visitWasm(uint32_t Rel, RelocationRef R, uint64_t Value) {
+    if (ObjToVisit.getArch() == Triple::wasm32) {
----------------
yurydelendik wrote:
> sbc100 wrote:
> > Where is this RelocVistor change used?  Can this be a separate change perhaps?
> This is needed to make llvm-dwarfdump not fail. It can be added in the separate change.
I guess we should add a test for  llvm-dwarfdump too?


Repository:
  rL LLVM

https://reviews.llvm.org/D44184





More information about the llvm-commits mailing list