[lld] r330036 - Reduce code duplication.
Rafael Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 13 09:07:28 PDT 2018
Author: rafael
Date: Fri Apr 13 09:07:27 2018
New Revision: 330036
URL: http://llvm.org/viewvc/llvm-project?rev=330036&view=rev
Log:
Reduce code duplication.
getVA was already implemented in the base class.
Modified:
lld/trunk/ELF/InputSection.h
lld/trunk/ELF/SyntheticSections.cpp
lld/trunk/ELF/SyntheticSections.h
Modified: lld/trunk/ELF/InputSection.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.h?rev=330036&r1=330035&r2=330036&view=diff
==============================================================================
--- lld/trunk/ELF/InputSection.h (original)
+++ lld/trunk/ELF/InputSection.h Fri Apr 13 09:07:27 2018
@@ -78,7 +78,7 @@ public:
// section.
uint64_t getOffset(uint64_t Offset) const;
- uint64_t getVA(uint64_t Offset) const;
+ uint64_t getVA(uint64_t Offset = 0) const;
protected:
SectionBase(Kind SectionKind, StringRef Name, uint64_t Flags,
Modified: lld/trunk/ELF/SyntheticSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=330036&r1=330035&r2=330036&view=diff
==============================================================================
--- lld/trunk/ELF/SyntheticSections.cpp (original)
+++ lld/trunk/ELF/SyntheticSections.cpp Fri Apr 13 09:07:27 2018
@@ -56,12 +56,6 @@ using llvm::support::endian::write64le;
constexpr size_t MergeNoTailSection::NumShards;
-uint64_t SyntheticSection::getVA() const {
- if (OutputSection *Sec = getParent())
- return Sec->Addr + OutSecOff;
- return 0;
-}
-
// Returns an LLD version string.
static ArrayRef<uint8_t> getVersion() {
// Check LLD_VERSION first for ease of testing.
Modified: lld/trunk/ELF/SyntheticSections.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.h?rev=330036&r1=330035&r2=330036&view=diff
==============================================================================
--- lld/trunk/ELF/SyntheticSections.h (original)
+++ lld/trunk/ELF/SyntheticSections.h Fri Apr 13 09:07:27 2018
@@ -52,7 +52,6 @@ public:
// If any additional finalization of contents are needed post thunk creation.
virtual void postThunkContents() {}
virtual bool empty() const { return false; }
- uint64_t getVA() const;
static bool classof(const SectionBase *D) {
return D->kind() == InputSectionBase::Synthetic;
More information about the llvm-commits
mailing list