[PATCH] D45316: [mips] Materialize constants for multiplication

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

Thanks for the review.



================
Comment at: lib/Target/Mips/MipsSEISelLowering.cpp:715
+
+  SmallVector<APInt, 16> WorkQueue(1, C);
+  unsigned Steps = 0;
----------------
I'll rename this to WorkStack.


================
Comment at: lib/Target/Mips/MipsSEISelLowering.cpp:732
+    APInt Ceil = Val.isNegative() ? APInt(BitWidth, 0) :
+                                APInt(BitWidth, 1) << C.ceilLogBase2();
+
----------------
atanasyan wrote:
> clang-format these lines
Will fix on commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D45316