[PATCH] D43025: [tsan] Add support for linux/powerpc64 in buildgo.sh

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

Much nicer now!
I think this is ready for commit after fixing these few nits.



================
Comment at: lib/tsan/go/buildgo.sh:59
+		SUFFIX="linux_amd64"
+		OSCFLAGS="-ffreestanding -Wno-unused-const-variable -Werror -Wno-unknown-warning-option"
+	fi
----------------
If I am reading this correctly, amd64 will not have -fPIC because this overrides whole OSCFLAGS rather than append to them. Do we need something like:
```
OSCFLAGS="$OSCFLAGS -ffreestanding -Wno-unused-const-variable -Werror -Wno-unknown-warning-option"
```
?


================
Comment at: lib/tsan/rtl/tsan_platform.h:414
+/* Go on linux/powerpc64 (46-bit VMA)
+0000 1000 0000 - 0000 1000 0000: executable
+0000 1000 0000 - 00c0 0000 0000: -
----------------
This should be:

0000 0000 1000 - 0000 1000 0000


================
Comment at: lib/tsan/rtl/tsan_platform.h:438
+/* Go on linux/powerpc64 (47-bit VMA)
+0000 1000 0000 - 0000 1000 0000: executable
+0000 1000 0000 - 00c0 0000 0000: -
----------------
This should be:

0000 0000 1000 - 0000 1000 0000


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43025