[PATCH] D45602: Define InitLLVM to do common initialization all at once.

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

There are several other tools that have similar initialization (but don't use GetArgumentVector). They should be updated also - and that will also fix their issue with UTF-8 on Windows.



================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:81
+int main(int Argc, const char **Argv) {
+  InitLLVM X(Argc, Argv);
 
----------------
By doing this in this file, ExitOnErr (which is used later in the main function) no longer has the banner set. I suspect the same may be true in some of the other files too. 

Perhaps InitLLVM could return an ExitOnError object which is already initialized with the correct banner?


https://reviews.llvm.org/D45602