[PATCH] D45330: [WIP][IPSCCP] Use PredicateInfo to propagate facts from cmp instructions.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D45330#1066015, @efriedma wrote:

> > I think number of instructions eliminated looks quite promising
>
> That's much better than I expected.  Although, I'm not sure how much I would trust that number; IPSCCP runs before CorrelatedValuePropagation, so you might be optimizing sequences which would be optimized later anyway.


I also aggregated all stats by CorrelatedValuePropagation for the same set of benchmarks: With this patch, CVP triggered in 23754 cases, without this patch it triggered  in 24904 cases. I guess this suggests some of the cases eliminated with this patch would also be handled by CVP. But the majority would not be.

One additional thing we could do by using PredicateInfo is propagate non-null constraints to call sites, which might help the inliner.


https://reviews.llvm.org/D45330