[PATCH] D45571: [ELF] - Speedup MergeInputSection::splitStrings

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputSection.cpp:903
   for (size_t I = 0; I != Size; I += EntSize)
     Pieces.emplace_back(I, xxHash64(toStringRef(Data.slice(I, EntSize))),
                         !IsAlloc);
----------------
espindola wrote:
> For consistency we should probably also replace this use of xxHash64.
I just did not find a good test for that place. I tried to do that change, but for Scylla, there was no difference, so decided to not do that in this patch to keep the focus on the main place.


https://reviews.llvm.org/D45571