[PATCH] D45550: Use GetArgumentVector to retrieve the utf-8 encoded arguments on all platforms

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 12 12:00:40 PDT 2018


efriedma added a comment.

> When Python 3 passes the command line argument to an external command, I believe it converts arguments to the current code page

That's not correct; Python 3 uses CreateProcessW, which accepts Unicode (UTF-16) directly, and if the called process uses GetCommandLineW, there's never any conversion.  Python 2 uses CreateProcessA, which has the issues you've noted.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45550





More information about the llvm-commits mailing list