[PATCH] D44782: Account for partial stack slot spills (PR30821)
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 12 10:16:53 PDT 2018
craig.topper added inline comments.
================
Comment at: lib/Target/X86/X86InstrInfo.cpp:3947
case X86::MOV8rm:
+ case X86::KMOVBkm:
case X86::MOV16rm:
----------------
These already exist at the bottom of the switch. This shouldn't even build.
================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4193
+// Is frame store, but with store size information
+static bool isFrameStoreOpcode(int Opcode, unsigned &MemBytes) {
+ switch (Opcode) {
----------------
Can we just have one version of these functions and just make the caller pass a dummy variable in for MemBytes when it doesn't need it? Or alternatively, pass MemBytes by pointer and pass a null pointer when it isn't needed. But that means a null pointer check before every assignment.
https://reviews.llvm.org/D44782
More information about the llvm-commits
mailing list