[PATCH] D45550: Use GetArgumentVector to retrieve the utf-8 encoded arguments on all platforms

[Aaron Smith via Phabricator via llvm-commits]

asmith added a comment.

If you look at the log for the test you will see we previously fixed it to work with Python 3. The test itself does not work on Windows for the reason your described.

Now look at https://reviews.llvm.org/D45551 which is the other part of these changes. You will see that we are reverting the change that we made previously to deal with the default code page on Windows. Eli pointed out it would be better to call GetArgumentVector and convert the command line to a UTF8 string.

Is your viewpoint that this test is bogus on Windows and should be marked XFAIL?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45550