[PATCH] D44909: [DAGCombine] (float)((int) f) --> ftrunc (PR36617)

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 11 18:49:41 PDT 2018


thakis added a comment.

This broke some large integration test on arm64 in Chromium (https://crbug.com/831145 – doesn't yet have any information other than "something is broken" and that we bisected it to this revision). It sounds like the patch got rewritten during review; does "formally allowed by the standard, but extremely likely to break things and surprise people" still apply? It sounds like this is supposed to be behavior-preserving for values that aren't NaN and Inf, but it does change behavior for those two? (If so, in what way?)


Repository:
  rL LLVM

https://reviews.llvm.org/D44909





More information about the llvm-commits mailing list