[PATCH] D45519: [ELF] - Change the way of sorting local symbols.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 11 17:17:45 PDT 2018


ruiu added a comment.

George, can you try to not use hash table like this in the future? Both this patch and your previous patch use a hash table to store a lot of symbols, which is a violation of the rule I set to achieve a good performance. If it is unavoidable, please explain in the commit message so that we can discuss and examine if it is really unavoidable. Just using a hash table without an explanation isn't good.


https://reviews.llvm.org/D45519





More information about the llvm-commits mailing list