[PATCH] D45536: Do not keep shared symbols to garbage-collected eliminated DSOs.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1065
+// created from the DSO. Otherwise, they become dangling references
+// that point to a non-exsitent DSO.
+template <class ELFT>
----------------
nit: non-existent


================
Comment at: lld/test/ELF/as-needed-weak.s:11
+
+# CHECK-NOT: libfoo
+
----------------
Won't this pass without the change?

Probably a better way to test this would be to check that foo is relocated properly.


https://reviews.llvm.org/D45536