[PATCH] D44313: [WebAssembly] Implement GC for imports
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 11 12:55:04 PDT 2018
sbc100 added a comment.
Mostly this LGTM. I like the addition of markLive() to the symbol class, although I know ruiu has objections to it. I think it makes sense since it is symmetric with the existing isLive() (which has precedence in COFF/Symbols.h)
In terms of doing the marking as part of GC or not I think I'm OK with this change, although I don't really consider globals to be sections. I think there is a wider discussion to be had about the utility of --no-gc-sections for wasm and what exactly it means.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D44313
More information about the llvm-commits
mailing list