[PATCH] D45021: [WebAssembly] Distinguish debug/symbol names in the Wasm structs. NFC
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 11 12:39:32 PDT 2018
sbc100 added a comment.
One comment, otherwise lgtm
================
Comment at: include/llvm/BinaryFormat/Wasm.h:104
+ StringRef SymbolName; // from the "linking" section
+ StringRef DebugName; // from the "name" section
uint32_t Comdat; // from the "comdat info" section
----------------
What do you think about dropping DebugName completely here? Since the name section is not really used in the object format right now this would make sense to me. If you really want to get to the debug names we have a method on the object to get them right?
Repository:
rL LLVM
https://reviews.llvm.org/D45021
More information about the llvm-commits
mailing list