[PATCH] D45459: [DWARFv5] Fuss with asm syntax for conveying an MD5 checksum
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 11 07:31:16 PDT 2018
probinson added a comment.
The leading zeros are because an MD5 hash is defined to be a 128-bit value. MD5Result::digest() returns the full 32-character hex string. I didn't see any value in trying to suppress leading zeros, it's slow and more likely to be confusing than helpful.
The parsing should automatically zero-extend a short value, and as it's identical to .octa parsing (see test\MC\AsmParser\directive_values.s) I didn't bother with one for MD5.
Repository:
rL LLVM
https://reviews.llvm.org/D45459
More information about the llvm-commits
mailing list