[PATCH] D44030: [WebAssembly] Tidy up handling of global symbol relocations

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

@sunfish, @dschuff, it's been another fortnight on this PR. If you don't want to look at it, or want to suggest another reviewer - that's fine, but it would be helpful to know, to get some feedback on whether I should by trying to get this in, or abandon it.

The main improvement in this PR is removing the strange `WebAssembly::fixup_code_global_index` fixup kind, and switching to using plain uleb32 fixups for global indexes, just the same as function index fixups currently do. Also I've pulled out some hardcoded constants into headers, and added an operand flag for globals to match the existing operand flag for function indexes (this is necessary to enable using the generic uleb32 fixup kind with globals).


Repository:
  rL LLVM

https://reviews.llvm.org/D44030