[PATCH] D44304: [MIPS GlobalISel] Select add i32, i32

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 11 04:37:38 PDT 2018


sdardis added a comment.

The LLVM-IR in the MIR test files doesn't match the MIR below, but I haven't checked if that makes a difference.



================
Comment at: test/CodeGen/Mips/GlobalISel/instruction-select/add.mir:5
+
+  define void @add_i32(i32 %x, i32 %y) {entry: ret void}
+
----------------
This IR doesn't match the MIR below.

This function takes two parameters, but doesn't return anything or perform any computation.

The MIR below does the trivial add two parameters and return the result.


https://reviews.llvm.org/D44304





More information about the llvm-commits mailing list