[PATCH] D45396: [DebugInfo] Create merged locations for instructions other than calls

[David Blaikie via llvm-commits]

0.6% increase to debug_line (assuming you checked & this didn't increase
anything else? Can't see how it could, but just checking - /maybe/ some
inlining/debug_ranges stuff?) seems acceptable to me.

On Tue, Apr 10, 2018 at 6:37 PM Adrian Prantl via Phabricator <
reviews at reviews.llvm.org> wrote:

> aprantl added a comment.
>
> I'm fine with this change since the result is more accurate than before
> (where the instruction would inherit whatever the previous instruction's
> location was.
>
> David: how do you feel about the size increase, since you brought that up?
>
>
>
> ================
> Comment at: include/llvm/IR/DebugInfoMetadata.h:1512
> +  /// is true, we will set the merged debug location as line 0 of the
> nearest
> +  /// common scope where 2 locations are inlined from.
> +  //
> ----------------
> `... common scope the the two locations.`
>
>
> https://reviews.llvm.org/D45396
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180411/ec42fdca/attachment.html>