[PATCH] D45375: [ELF] - Introduce synthetic file for linker script symbols.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

Please rebase.



================
Comment at: ELF/InputFiles.h:73
+
+  static InputFile* createSyntheticFile(StringRef Name);
+
----------------
clang-format


================
Comment at: ELF/LTO.cpp:162
         // will be generated by for them, triggering linker errors.
-        // Symbol section is always null for bitcode symbols, hence the check
-        // for isElf(). Skip linker script defined symbols as well: they have
----------------
You should keep the comment about the section symbol being null for bitcode symbols, that is why we need the isa<BitcodeFile>


https://reviews.llvm.org/D45375