[PATCH] D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 13:32:19 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D44406, I was imagining instead that we'd mark DISubprograms as trivial or non-trivial, not the type itself, and then CodeViewDebug.cpp in LLVM could skip trivial constructors when looking for classes.

I think for CxxReturnUdt we can go ahead and use the DIFlagPassByReference marker. The flag name isn't really accurate since it also covers cases that would use inalloca. My ideas aren't that much better, though: DIFlagPassingIsNonTrivial, DIFlagCopyIsNonTrivial, DIFlagNonTriviallyCopyable, blech.


Repository:
  rL LLVM

https://reviews.llvm.org/D45122





More information about the llvm-commits mailing list