[PATCH] D45473: CodeGen: Don't try to canonicalize Unix-style paths in CodeView debug info.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 13:23:17 PDT 2018


pcc added a comment.

In https://reviews.llvm.org/D45473#1063321, @rnk wrote:

> Can you elaborate on the use case? What tool do you expect will consume these Unix style paths?


We can use the paths to provide better linker error messages. See https://reviews.llvm.org/D45467.

> What aspect of the path is invalidated by changing the slash style?

It means for example that users can't copy the path out of the linker error message and paste it to their editor.

> I think the right way to address these distributed cross-compilation use cases is probably going to be to have a flag like "-fdebug-compilation-dir" that the build system supplies with a Windows-style drive letter path.

Yes this is one example of a case where a  "foreign" path ends up being embedded in the directory component of a debug info path and the code generator will need to respect that and not the path convention of the host machine. A similar situation is where the frontend is run on the local machine and the backend runs on the remote machine -- this is the distributed thinlto situation. In that case the frontend will "naturally" embed host-style paths in the directory component of debug info paths and the backend will again need to respect them.


https://reviews.llvm.org/D45473





More information about the llvm-commits mailing list