[PATCH] D44611: [CodeGen] Allow printing MachineMemOperands with less context in SDAGDumper

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 11:28:29 PDT 2018


bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

Would this be easier to follow if we overloaded printMemOperand with a variant that took the variables we're declaring here (M, MF, etc) and simply called into it? The "if (G)" condition would set them up and the "else" side would just pass null pointers.

In any case, LGTM. Feel free to commit once you've tried that and decided which is better.


https://reviews.llvm.org/D44611





More information about the llvm-commits mailing list