[PATCH] D45487: [tsan] Add interceptors for objc_sync_enter and objc_sync_exit

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 11:06:42 PDT 2018


kubamracek added a comment.

In https://reviews.llvm.org/D45487#1063319, @george.karpenkov wrote:

> Would it be hard to add another test where those interceptors do produce a warning?


Whaat kind of test are you looking for? As this adds more synchronization edges, this strictly removes reports (false positives in this case). I can add a test that incorrectly uses `@synchronized` that still triggers a TSan report, if you want.


https://reviews.llvm.org/D45487





More information about the llvm-commits mailing list