[PATCH] D45487: [tsan] Add interceptors for objc_sync_enter and objc_sync_exit

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 10:56:34 PDT 2018


delcypher added inline comments.


================
Comment at: lib/tsan/CMakeLists.txt:121
     LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS} ${WEAK_SYMBOL_LINK_FLAGS}
-    LINK_LIBS ${TSAN_LINK_LIBS}
+    LINK_LIBS ${TSAN_LINK_LIBS} objc
     PARENT_TARGET tsan)
----------------
Does this mean that `clang_rt.tsan` will now **always** link against `libobjc`? Is that really necessary. Won't that mean it gets linked in for sanitized C programs that have absolutely no business doing anything with the ObjectiveC runtime?


https://reviews.llvm.org/D45487





More information about the llvm-commits mailing list