[PATCH] D45276: Fix a couple of incorrect fields in our generated PDBs.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good, feel free to address the is64() check in a follow-up.



================
Comment at: lld/COFF/PDB.cpp:1091
   DbiBuilder.setVersionHeader(pdb::PdbDbiV70);
+  DbiBuilder.setMachineType(Config->is64() ? pdb::PDB_Machine::Amd64
+                                           : pdb::PDB_Machine::x86);
----------------
arm-chrjan01 wrote:
> This should use Configuration::Machine rather than Configuration::is64. Configuration::is64 will return true for ARM64, for example, and this condition then goes on to assume it's AMD64.
This one seems still unaddressed.


https://reviews.llvm.org/D45276