[PATCH] D45493: [Polly][NewPM] Port IslAst, ScopDetect, and ScopInfo lit testsuites over to the new PM

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Instead of adding `-aa-pipeline=basic-aa` everywhere, did you consider adding it to `%loadPolly`, or only add it if the test otherwise fails?

This will double the time a check-polly run takes, which I unfortunately cannot get too excited about. For new test cases, do we then also have to consider the new pass manager?
My suggestion is to wait with this change until we want to make the new PM the main implementation, instead of maintaining two PMs in parallel. The script can be applied anytime, and even added to the repository.



================
Comment at: test/Isl/CodeGen/20100708.ll:1
+; RUN: opt %loadPolly "-passes=require<polly-detect>" < %s 2>&1                \
+; RUN: -aa-pipeline=basic-aa
----------------
Could you try to do something more intelligent than merging stdout and stderr everywhere? How they are interleaved is undefined, and we risk indeterministic test failures.


================
Comment at: test/Isl/CodeGen/conflict-between-loop-invariant-code-hosting-and-escape-map-computation.ll:1
+; RUN: opt %loadPolly -polly-process-unprofitable -disable-output              \
+; RUN: -passes=polly-codegen < %s 2>&1 -aa-pipeline=basic-aa
----------------
Could you can tell your script to remove `-polly-process-unprofitable`, which is added by %loadPolly anyway?


Repository:
  rPLO Polly

https://reviews.llvm.org/D45493