[PATCH] D44928: [MC] Pass MCSubtargetInfo to fixupNeedsRelaxation and applyFixup

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 07:32:40 PDT 2018


peter.smith added a comment.

Thanks for the comments. I think your second  one brings up a couple of wider problems that I'll need to address:

- getOrCreateDataFragment() needs to start a new fragment when the original contains instructions and the new one has a different Subtarget. Otherwise the later Subtarget will overwrite the first, I don't think that this makes any practical difference for the MCAsmBackend functions changed in this patch, however it will do for the WriteNops().
- For instruction bundling in cases where the previous fragment must be used then it must either have the same Subtarget, or we permit the later Subtarget to overwrite the first.

I'm going to be away from the office for the next 7 days for a couple of conferences (including Euro LLVM) so I'll get back to this then.


https://reviews.llvm.org/D44928





More information about the llvm-commits mailing list