[PATCH] D45167: Use sys::fs::real_path() instead of realpath() in Symbolize and remove HAVE_REALPATH.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 06:24:15 PDT 2018


hans added inline comments.


================
Comment at: lib/DebugInfo/Symbolize/Symbolize.cpp:173
+  SmallString<256> OrigRealPath;
+  if (sys::fs::real_path(OrigPath, OrigRealPath))
+    OrigRealPath = OrigPath;
----------------
Yes, seems to be missing a not operator. I find std::error_code confusing.


https://reviews.llvm.org/D45167





More information about the llvm-commits mailing list