[PATCH] D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess()

[SAHIL GIRISH YERAWAR via Phabricator via llvm-commits]

cs15btech11044 added inline comments.


================
Comment at: lib/Analysis/ScopInfo.cpp:2306-2308
   if (isl_set_n_basic_set(Set.get()) >= MaxDisjunctsInDomain)
     return isl::stat::error;
 
----------------
I would like to have an opinion on this part of codebase here.

Since the operation of `simple_hull` tries to reduce the number of disjuncts present in the set. Can we conditionally call `simple_hull` only when `MaxDisjunctsInDomain` is triggered?
In other words, I am proposing to replace

```
if (isl_set_n_basic_set(Set.get()) >= MaxDisjunctsInDomain)
    return isl::stat::error;
```

with


```
if (isl_set_n_basic_set(Set.get()) >= MaxDisjunctsInDomain)
    Set = Set.simple_hull();
if (isl_set_n_basic_set(Set.get()) >= MaxDisjunctsInDomain)
    return isl::stat::error;
```


https://reviews.llvm.org/D45066